On Wed, Aug 20, 2025 at 12:50:25PM +0200, Alejandro Colomar wrote:

Hi Lorenzo,

On Tue, Aug 19, 2025 at 09:37:39PM +0100, Lorenzo Stoakes wrote:

quoted

quoted

quoted

diff --git a/man/man2/mremap.2 b/man/man2/mremap.2
index 6d14bf627..53d4eda29 100644
--- a/man/man2/mremap.2
+++ b/man/man2/mremap.2

@@ -47,8 +47,35 @@ The
 .B MREMAP_DONTUNMAP
 flag may also be specified.
 .P
-If the operation is not
-simply moving mappings,
+Equally, if the operation performs a shrink,

I've changed s/Equally/Similarly/

quoted

quoted

quoted

+that is if

Missing comma.

Could you fix that up? Thnks!

quoted

quoted

+.I old_size
+is greater than
+.IR new_size ,
+then
+.I old_size
+may also span multiple mappings
+which do not have to be
+adjacent to one another.

I'm wondering if there's a missing comma or not before 'which'.
The meaning of the sentence would be different.

So, I should ask:

Does old_size > new_size mean that old_size may span multiple mappings
and you're commenting that multiple mappings need not be adjacent?

Yes.

quoted

Or are multiple mappings always allowed and old_size > new_size allows
non-adjacent ones?

No.

quoted

I suspect it's the former, right?  Then, it's missing a comma, right?

Yes could you fix that up?

Yup.

quoted

quoted

Other than this, the patch looks good.

Thanks!

Thanks for the patch!  I've applied it with those amendments.
<https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib&id=21b1c7188ce1d66ef294eb1681361315a35e8070>

All sounds good, thanks for doing that and also for applies for other patches in
series :)

Cheers, Lorenzo

Have a lovely day!
Alex

--
<https://www.alejandro-colomar.es/>