Thread (47 messages) 47 messages, 5 authors, 2025-07-23

Re: [PATCH v1 03/32] kho: warn if KHO is disabled due to an error

From: Pasha Tatashin <pasha.tatashin@soleen.com>
Date: 2025-07-23 14:40:03
Also in: linux-doc, linux-fsdevel, linux-mm, lkml

On Wed, Jun 25, 2025 at 11:57 PM Randy Dunlap [off-list ref] wrote:


On 6/25/25 4:17 PM, Pasha Tatashin wrote:
quoted
During boot scratch area is allocated based on command line
parameters or auto calculated. However, scratch area may fail
to allocate, and in that case KHO is disabled. Currently,
no warning is printed that KHO is disabled, which makes it
confusing for the end user to figure out why KHO is not
available. Add the missing warning message.
Are users even going to know what "KHO" means in the warning message?
Changed warning to: Failed to reserve scratch area, disabling kexec handover
quoted
Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
---
 kernel/kexec_handover.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/kernel/kexec_handover.c b/kernel/kexec_handover.c
index 1ff6b242f98c..069d5890841c 100644
--- a/kernel/kexec_handover.c
+++ b/kernel/kexec_handover.c
@@ -565,6 +565,7 @@ static void __init kho_reserve_scratch(void)
 err_free_scratch_desc:
      memblock_free(kho_scratch, kho_scratch_cnt * sizeof(*kho_scratch));
 err_disable_kho:
+     pr_warn("Failed to reserve scratch area, disabling KHO\n");
      kho_enable = false;
 }
--
~Randy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help