Re: [PATCH v11 02/16] xfs: only call xfs_setsize_buftarg once per buffer target
From: Christoph Hellwig <hch@lst.de>
Date: 2025-05-05 10:49:06
Also in:
linux-block, linux-ext4, linux-fsdevel, linux-xfs, lkml
On Mon, May 05, 2025 at 11:04:55AM +0100, John Garry wrote:
quoted hunk ↗ jump to hunk
@@ -503,6 +509,9 @@ xfs_open_devices( mp->m_logdev_targp = xfs_alloc_buftarg(mp, logdev_file); if (!mp->m_logdev_targp) goto out_free_rtdev_targ; + error = sync_blockdev(mp->m_logdev_targp->bt_bdev); + if (error) + goto out_free_rtdev_targ; } else { mp->m_logdev_targp = mp->m_ddev_targp; /* Handle won't be used, drop it */Right?
Yes. Or in fact just folding it into xfs_alloc_buftarg, which might be even simpler. While you're at it adding a command why we are doing the sync would also be really useful, and having it in just one place helps with that.