Re: [PATCH v7 2/6] selftests/pidfd: add missing system header imcludes to pidfd tests
From: Peter Seiderer <hidden>
Date: 2025-02-05 12:06:55
Also in:
linux-fsdevel, linux-kselftest, linux-mm, lkml
Hello *, On Thu, 30 Jan 2025 20:40:27 +0000, Lorenzo Stoakes [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The pidfd_fdinfo_test.c and pidfd_setns_test.c tests appear to be missing fundamental system header imports required to execute correctly. Add these. Signed-off-by: Lorenzo Stoakes <redacted> --- tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 1 + tools/testing/selftests/pidfd/pidfd_setns_test.c | 1 + 2 files changed, 2 insertions(+)diff --git a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c index f062a986e382..f718aac75068 100644 --- a/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c +++ b/tools/testing/selftests/pidfd/pidfd_fdinfo_test.c@@ -13,6 +13,7 @@ #include <syscall.h> #include <sys/wait.h> #include <sys/mman.h> +#include <sys/mount.h> #include "pidfd.h" #include "../kselftest.h"
Predated patch already available, see https://lore.kernel.org/linux-kselftest/20250115105211.390370-1-ps.report@gmx.net/ (local)
quoted hunk ↗ jump to hunk
diff --git a/tools/testing/selftests/pidfd/pidfd_setns_test.c b/tools/testing/selftests/pidfd/pidfd_setns_test.c index 222f8131283b..a55f6641e0b6 100644 --- a/tools/testing/selftests/pidfd/pidfd_setns_test.c +++ b/tools/testing/selftests/pidfd/pidfd_setns_test.c@@ -14,6 +14,7 @@ #include <sys/prctl.h> #include <sys/wait.h> #include <unistd.h> +#include <sys/ioctl.h> #include <sys/socket.h> #include <sys/stat.h> #include <linux/ioctl.h>
and predated patch available, see https://lore.kernel.org/linux-kselftest/20250115105211.390370-2-ps.report@gmx.net/ (local) Regards, Peter