On 24.10.24 09:34, Lorenzo Stoakes wrote:

On Wed, Oct 23, 2024 at 04:04:05PM -0700, Andrew Morton wrote:

quoted

On Wed, 23 Oct 2024 17:24:38 +0100 Lorenzo Stoakes [off-list ref] wrote:

quoted

...

Existing mechanism for performing a walk which also installs page table
entries if necessary are heavily duplicated throughout the kernel,

How complicated is it to migrate those to use this?

I would say probably somewhat difficult as very often people are doing quite
custom things, but I will take a look at seeing if we can't make things a little
more generic.

I am also mildly motivated to look at trying to find a generic way to do
replaces...

Both on the TODO!

I'm not super happy about extending the rusty old pagewalk API, because 
it's inefficient (indirect calls) and not future proof (batching, large 
folios).

But I see how we ended up with this patch, and it will be easy to 
convert to something better once we have it.

We already discussed in the past that we need a better and more 
efficient way to walk page tables. I have part of that on my TODO list, 
but I'm getting distracted.

*Inserting* (not walking/modifying existing things as most users to) as 
done in this patch is slightly different though, likely "on thing that 
fits all" will not apply to all page table walker user cases.

-- 
Cheers,

David / dhildenb