Re: [PATCH RFT v7 9/9] selftests/clone3: Test shadow stack support

On Wed, Aug 07, 2024 at 11:03:24PM +0100, Mark Brown wrote:

On Wed, Aug 07, 2024 at 12:23:01PM -0700, Kees Cook wrote:

quoted

On Wed, Aug 07, 2024 at 01:39:27PM +0100, Mark Brown wrote:

quoted

quoted

 		size = args->shadow_stack_size;
+		shstk->base = 0;
+		shstk->size = 0;

quoted

Yup, that fixes it!

quoted

  # Totals: pass:23 fail:0 xfail:0 xpass:0 skip:1 error:0

quoted

(The skip is "Shadow stack on system without shadow stack")

Excellent, thanks!  It's amazing how many dumb mistakes you can find if
you actually try running the code :/ .

Heh, well, it's tricky work writing it without reference hardware. :) I
just wish there was CET emulation in QEmu...

-- 
Kees Cook