Re: [PATCH] syscalls: fix syscall macros for newfstat/newfstatat
From: Jakub Jelinek <hidden>
Date: 2024-08-05 19:54:02
Also in:
linux-arm-kernel, linux-riscv, lkml, loongarch
On Sat, Aug 03, 2024 at 10:12:47AM +0200, Arnd Bergmann wrote:
quoted
Probably it would be useful to check echo '#include <asm/unistd.h>' | gcc -E -dD -xc - | grep '#define __NR_' | sort for all arches between 6.10 and the latest git, diff them and resolve any unintended differences.Right, I should have done that before the original series really: I spent a lot of time validating the kernel's internal changes for consistency (which found a dozen bugs that were unrelated to my series) but missed the unintended changes to the external header contents. I'll do that now and send another fixup.
I've done 6.10 to 6.11-rc2 <asm/unistd.h> comparison just for the Fedora arches (x86_64, aarch64, ppc64le, s390x, i686). Full details in https://bugzilla.redhat.com/show_bug.cgi?id=2301919#c8 On i686, ppc64le and s390x there are no changes. On x86_64 #define __NR_uretprobe 335 has been added, perhaps that is intentional, haven't checked. On aarch64 when going just after __NR_ defined macros and their values, I see: #define __NR_nfsservctl 42 #define __NR_fstat 80 #define __NR_arch_specific_syscall 244 #define __NR_syscalls 463 removal and #define __NR_newfstat 80 and addition and then #define __NR3264_fcntl 25 #define __NR3264_statfs 43 #define __NR3264_fstatfs 44 #define __NR3264_truncate 45 #define __NR3264_ftruncate 46 #define __NR3264_lseek 62 #define __NR3264_sendfile 71 #define __NR3264_fstatat 79 #define __NR3264_fstat 80 #define __NR3264_mmap 222 #define __NR3264_fadvise64 223 macros are removed as well (let's hope it is an implementation detail and nothing uses those macros, but some search would be helpful). Jakub