Re: [PATCH v7] posix-timers: add clock_compare system call

From
Thomas Gleixner <hidden>
Date
2024-03-14 18:42:53
Also in
linux-arch, lkml, netdev
Reply to
Sagi Maimon, 2024-03-14
On Thu, Mar 14 2024 at 17:46, Sagi Maimon wrote:

Can you please trim your replies? I really have better things to do than
doing detective work to find 10 new lines within 200+ irrelevant ones.
On Thu, Mar 14, 2024 at 1:12 PM Thomas Gleixner [off-list ref] wrote:
quoted
Please read and follow the documentation provided at:

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html
I have missed this part on prviews reply.
I have read the documentation above and I think that the variable
declarations at the beginning of a function is in reverse fir tree
order meaning from big to small, but I guess that I am missing something,
can you please explain what is wrong with the variable declaration,
so I can fix it.
quoted
quoted
+     struct timespec64 ts_a, ts_a1, ts_b, ts_a2;
+     struct system_device_crosststamp xtstamp_a1, xtstamp_a2, xtstamp_b;
+     const struct k_clock *kc_a, *kc_b;
+     ktime_t ktime_a;
+     s64 ts_offs_err = 0;
+     int error = 0;
+     bool crosstime_support_a = false;
+     bool crosstime_support_b = false;
It's not about the data type. Look at the three layouts and figure out
which one is better to parse.
Thread (26 messages) 26 messages, 5 authors, last reply 2024-04-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help