Re: [PATCH net-next v6 1/4] eventpoll: support busy poll per epoll instance
From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-02-07 20:11:25
Also in:
linux-fsdevel, lkml, netdev
On Wed, 7 Feb 2024 11:14:08 -0800 Joe Damato wrote:
quoted
Why do we need u64 for usecs? I think u16 would do, and u32 would give a very solid "engineering margin". If it was discussed in previous versions I think it's worth explaining in the commit message.In patch 4/4 the value is limited to U32_MAX, but if you prefer I use a u32 here instead, I can make that change.
Unless you have a clear reason not to, I think using u32 would be more natural? If my head math is right the range for u32 is 4096 sec, slightly over an hour? I'd use u32 and limit it to S32_MAX.