Re: [PATCH v2 1/2] signal: add the "int si_code" arg to prepare_kill_siginfo()

On Fri, Feb 09, 2024 at 08:36:24PM +0100, Christian Brauner wrote:

On Fri, Feb 09, 2024 at 05:39:14PM +0100, Oleg Nesterov wrote:

quoted

On 02/09, Eric W. Biederman wrote:

quoted

Could you can pass in the destination type instead of the si_code?
Something like I have shown below?

...

quoted

	info->si_code = (type == PIDTYPE_PID) ? SI_TKILL : SI_USER;

Yes, I considered this option too.

OK, will send V3 tomorrow.

Hm, I don't think that's necessary if you're happy to have me just fix
that up in tree. Here's the two patches updated. It was straightforward
but I have a baby on my lap so double check, please:

From 05ffda39f6f5c887cae319274366cbf856c88fe5 Mon Sep 17 00:00:00 2001
From: Oleg Nesterov <oleg@redhat.com>
Date: Fri, 9 Feb 2024 14:06:20 +0100
Subject: [PATCH 1/2] signal: fill in si_code in prepare_kill_siginfo()

So that do_tkill() can use this helper too. This also simplifies
the next patch.

TODO: perhaps we can kill prepare_kill_siginfo() and change the
callers to use SEND_SIG_NOINFO,  but this needs some changes in
__send_signal_locked() and TP_STORE_SIGINFO().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Link: https://lore.kernel.org/r/20240209130620.GA8039@redhat.com (local)
Signed-off-by: Christian Brauner <brauner@kernel.org>

Looks good to me as well,

Reviewed-by: Tycho Andersen <redacted>