Re: [PATCH v4 6/6] wire up syscalls for statmount/listmount
From: Florian Fainelli <florian.fainelli@broadcom.com>
Date: 2024-01-09 01:11:46
Also in:
linux-fsdevel, linux-man, linux-security-module, lkml
Hello, On 10/25/23 07:02, Miklos Szeredi wrote:
Wire up all archs. Signed-off-by: Miklos Szeredi <redacted> --- arch/alpha/kernel/syscalls/syscall.tbl | 3 +++ arch/arm/tools/syscall.tbl | 3 +++ arch/arm64/include/asm/unistd32.h | 4 ++++ arch/ia64/kernel/syscalls/syscall.tbl | 3 +++ arch/m68k/kernel/syscalls/syscall.tbl | 3 +++ arch/microblaze/kernel/syscalls/syscall.tbl | 3 +++ arch/mips/kernel/syscalls/syscall_n32.tbl | 3 +++ arch/mips/kernel/syscalls/syscall_n64.tbl | 3 +++ arch/mips/kernel/syscalls/syscall_o32.tbl | 3 +++ arch/parisc/kernel/syscalls/syscall.tbl | 3 +++ arch/powerpc/kernel/syscalls/syscall.tbl | 3 +++ arch/s390/kernel/syscalls/syscall.tbl | 3 +++ arch/sh/kernel/syscalls/syscall.tbl | 3 +++ arch/sparc/kernel/syscalls/syscall.tbl | 3 +++ arch/x86/entry/syscalls/syscall_32.tbl | 3 +++ arch/x86/entry/syscalls/syscall_64.tbl | 2 ++ arch/xtensa/kernel/syscalls/syscall.tbl | 3 +++ include/uapi/asm-generic/unistd.h | 8 +++++++- 18 files changed, 58 insertions(+), 1 deletion(-)
FWIW, this broke the compat build on ARM64:
./arch/arm64/include/asm/unistd32.h:922:24: error: array index in
initializer exceeds array bounds
922 | #define __NR_statmount 457
| ^~~
arch/arm64/kernel/sys32.c:130:34: note: in definition of macro '__SYSCALL'
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~
./arch/arm64/include/asm/unistd32.h:923:11: note: in expansion of macro
'__NR_statmount'
923 | __SYSCALL(__NR_statmount, sys_statmount)
| ^~~~~~~~~~~~~~
./arch/arm64/include/asm/unistd32.h:922:24: note: (near initialization
for 'compat_sys_call_table')
922 | #define __NR_statmount 457
| ^~~
arch/arm64/kernel/sys32.c:130:34: note: in definition of macro '__SYSCALL'
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~
./arch/arm64/include/asm/unistd32.h:923:11: note: in expansion of macro
'__NR_statmount'
923 | __SYSCALL(__NR_statmount, sys_statmount)
| ^~~~~~~~~~~~~~
arch/arm64/kernel/sys32.c:130:40: warning: excess elements in array
initializer
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
./arch/arm64/include/asm/unistd32.h:923:1: note: in expansion of macro
'__SYSCALL'
923 | __SYSCALL(__NR_statmount, sys_statmount)
| ^~~~~~~~~
arch/arm64/kernel/sys32.c:130:40: note: (near initialization for
'compat_sys_call_table')
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
./arch/arm64/include/asm/unistd32.h:923:1: note: in expansion of macro
'__SYSCALL'
923 | __SYSCALL(__NR_statmount, sys_statmount)
| ^~~~~~~~~
./arch/arm64/include/asm/unistd32.h:924:24: error: array index in
initializer exceeds array bounds
924 | #define __NR_listmount 458
| ^~~
arch/arm64/kernel/sys32.c:130:34: note: in definition of macro '__SYSCALL'
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~
./arch/arm64/include/asm/unistd32.h:925:11: note: in expansion of macro
'__NR_listmount'
925 | __SYSCALL(__NR_listmount, sys_listmount)
| ^~~~~~~~~~~~~~
./arch/arm64/include/asm/unistd32.h:924:24: note: (near initialization
for 'compat_sys_call_table')
924 | #define __NR_listmount 458
| ^~~
arch/arm64/kernel/sys32.c:130:34: note: in definition of macro '__SYSCALL'
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~
./arch/arm64/include/asm/unistd32.h:925:11: note: in expansion of macro
'__NR_listmount'
925 | __SYSCALL(__NR_listmount, sys_listmount)
| ^~~~~~~~~~~~~~
arch/arm64/kernel/sys32.c:130:40: warning: excess elements in array
initializer
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
./arch/arm64/include/asm/unistd32.h:925:1: note: in expansion of macro
'__SYSCALL'
925 | __SYSCALL(__NR_listmount, sys_listmount)
| ^~~~~~~~~
arch/arm64/kernel/sys32.c:130:40: note: (near initialization for
'compat_sys_call_table')
130 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym,
| ^~~~~~~~
./arch/arm64/include/asm/unistd32.h:925:1: note: in expansion of macro
'__SYSCALL'
925 | __SYSCALL(__NR_listmount, sys_listmount)
| ^~~~~~~~~
host-make[5]: *** [scripts/Makefile.build:243:
arch/arm64/kernel/sys32.o] Error 1
host-make[4]: *** [scripts/Makefile.build:480: arch/arm64/kernel] Error 2
host-make[3]: *** [scripts/Makefile.build:480: arch/arm64] Error 2
host-make[3]: *** Waiting for unfinished jobs....
Sent out a fix for that:
https://lore.kernel.org/all/20240109010906.429652-1-florian.fainelli@broadcom.com/ (local)
--
Florian
Attachments
- smime.p7s [application/pkcs7-signature] 4221 bytes