Thread (26 messages) 26 messages, 4 authors, 2023-11-28

Re: [RFC PATCH 02/11] mm/mempolicy: swap cond reference counting logic in do_get_mempolicy

From: Michal Hocko <mhocko@suse.com>
Date: 2023-11-28 14:07:18
Also in: linux-arch, linux-doc, linux-fsdevel, linux-mm, lkml

On Wed 22-11-23 16:11:51, Gregory Price wrote:
[...]
quoted hunk ↗ jump to hunk
@@ -982,11 +991,11 @@ static long do_get_mempolicy(int *policy, nodemask_t *nmask,
 	}
 
  out:
-	mpol_cond_put(pol);
+	mpol_put(pol);
 	if (vma)
 		mmap_read_unlock(mm);
 	if (pol_refcount)
-		mpol_put(pol_refcount);
+		mpol_cond_put(pol_refcount);
Maybe I am just misreading the patch but pol_refcount should be always
NULL with this patch
 	return err;
 }
 
-- 
2.39.1
-- 
Michal Hocko
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help