Thread (10 messages) 10 messages, 6 authors, 2023-10-03

Re: [PATCH v2] syscalls: Cleanup references to sys_lookup_dcookie()

From: Sohil Mehta <hidden>
Date: 2023-10-03 17:47:27
Also in: linux-alpha, linux-arch, linux-m68k, linux-mips, linux-perf-users, linux-s390, linux-sh, linuxppc-dev, lkml, sparclinux

Arnd, is this a good candidate for 6.7? Though old, the patch applies
cleanly on 6.6-rc4. I can re-send this one if you would prefer that.

On 8/3/2023 2:44 PM, Sohil Mehta wrote:
On 7/10/2023 11:51 AM, Sohil Mehta wrote:
quoted
commit 'be65de6b03aa ("fs: Remove dcookies support")' removed the
syscall definition for lookup_dcookie.  However, syscall tables still
point to the old sys_lookup_dcookie() definition. Update syscall tables
of all architectures to directly point to sys_ni_syscall() instead.

Signed-off-by: Sohil Mehta <redacted>
Reviewed-by: Randy Dunlap <redacted>
Acked-by: Namhyung Kim <namhyung@kernel.org> # for perf
The patch has received a couple of additional Acks.
Namely,

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Russell King (Oracle) <redacted>
Does this seem like a valuable cleanup? If so, should it go through the
asm-generic tree?
The main motivation here is to make readers aware upfront (via the
syscall table itself) that no implementation exists for lookup_dcookie
instead of them searching for one and realizing the same. The syscall
tables do something similar for _sysctl().

Please let me know if this change seems unnecessary. I can drop the
annoying pings in that case.

Thanks,
Sohil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help