Re: [PATCH v8 07/12] landlock: Add network rules support
From: Konstantin Meskhidze (A) <hidden>
Date: 2023-01-09 12:19:00
Also in:
linux-security-module, netdev, netfilter-devel
1/9/2023 2:53 PM, Dan Carpenter пишет:
On Mon, Jan 09, 2023 at 02:39:36PM +0300, Konstantin Meskhidze (A) wrote:quoted
1/9/2023 1:20 PM, Dan Carpenter пишет:quoted
On Mon, Jan 09, 2023 at 12:26:52PM +0300, Konstantin Meskhidze (A) wrote:quoted
1/9/2023 11:58 AM, Dan Carpenter пишет:quoted
These warnings seem like something I have seen before. Maybe it was an issue with _Generic() support?quoted
Are you really sure you're running the latest git version ofSparse?quoted
quoted
I tested this patch with the latest version of Sparse on mysystem andquoted
it worked fine.Hi Dan, git is on the master branch now - hash ce1a6720 (dated 27 June 2022) Is this correct version?Yes, that's correct. What is your .config?What parameters do I need to check in .config?I don't know. I was hoping you could just email me the whole thing and/or the results from make security/landlock/ruleset.i. That way we could see what line was making Sparse complain.
here is the whole error message: make C=2 security/landlock/ CHECK scripts/mod/empty.c CALL scripts/checksyscalls.sh DESCEND objtool DESCEND bpf/resolve_btfids CHECK security/landlock/setup.c ./include/asm-generic/rwonce.h:67:16: error: typename in expression ./include/asm-generic/rwonce.h:67:16: error: Expected ) in function call ./include/asm-generic/rwonce.h:67:16: error: got : ./include/linux/list.h:292:16: error: typename in expression ./include/linux/list.h:292:16: error: Expected ) in function call ./include/linux/list.h:292:16: error: got : ./include/linux/list.h:328:34: error: typename in expression ./include/linux/list.h:328:34: error: Expected ) in function call ./include/linux/list.h:328:34: error: got : ./include/linux/list.h:329:53: error: typename in expression ./include/linux/list.h:329:53: error: Expected ) in function call ./include/linux/list.h:329:53: error: got : ./include/linux/list.h:867:17: error: typename in expression ./include/linux/list.h:867:17: error: Expected ) in function call ./include/linux/list.h:867:17: error: got : ./include/linux/list.h:876:17: error: typename in expression ./include/linux/list.h:876:17: error: Expected ) in function call ./include/linux/list.h:876:17: error: got : ./arch/x86/include/asm/atomic.h:29:16: error: typename in expression ./arch/x86/include/asm/atomic.h:29:16: error: Expected ) in function call ./arch/x86/include/asm/atomic.h:29:16: error: got : ./arch/x86/include/asm/atomic64_64.h:22:16: error: typename in expression ./arch/x86/include/asm/atomic64_64.h:22:16: error: Expected ) in function call ./arch/x86/include/asm/atomic64_64.h:22:16: error: got : ./include/linux/atomic/atomic-arch-fallback.h:227:23: error: typename in expression ./include/linux/atomic/atomic-arch-fallback.h:227:23: error: Expected ) in function call ./include/linux/atomic/atomic-arch-fallback.h:227:23: error: got : ./include/linux/atomic/atomic-arch-fallback.h:1348:23: error: typename in expression ./include/linux/atomic/atomic-arch-fallback.h:1348:23: error: Expected ) in function call ./include/linux/atomic/atomic-arch-fallback.h:1348:23: error: got : ./include/linux/jump_label.h:286:9: error: Expected ; at end of statement ./include/linux/jump_label.h:286:9: error: got __flags ./include/linux/jump_label.h:302:9: error: Expected ; at end of statement ./include/linux/jump_label.h:302:9: error: got __flags ./include/linux/jump_label.h:319:9: error: Expected ; at end of statement ./include/linux/jump_label.h:319:9: error: got __flags ./include/linux/jump_label.h:322:17: error: Expected ; at end of statement ./include/linux/jump_label.h:322:17: error: got __flags ./include/linux/jump_label.h:330:9: error: Expected ; at end of statement ./include/linux/jump_label.h:330:9: error: got __flags ./include/linux/jump_label.h:333:17: error: Expected ; at end of statement ./include/linux/jump_label.h:333:17: error: got __flags ./include/asm-generic/bitops/generic-non-atomic.h:140:23: error: typename in expression ./include/asm-generic/bitops/generic-non-atomic.h:140:23: error: Expected ) in function call ./include/asm-generic/bitops/generic-non-atomic.h:140:23: error: got : ./include/linux/bitmap.h:268:17: error: Expected ; at end of statement ./include/linux/bitmap.h:268:17: error: got __flags ./include/linux/thread_info.h:127:16: error: typename in expression ./include/linux/thread_info.h:127:16: error: Expected ) in function call ./include/linux/thread_info.h:127:16: error: got : ./include/linux/thread_info.h:233:13: error: Expected ; at end of statement ./include/linux/thread_info.h:233:13: error: got __flags ./include/linux/llist.h:191:16: error: typename in expression ./include/linux/llist.h:191:16: error: Expected ) in function call ./include/linux/llist.h:191:16: error: got : ./include/linux/rcupdate.h:1073:31: error: typename in expression ./include/linux/rcupdate.h:1073:31: error: Expected ) in function call ./include/linux/rcupdate.h:1073:31: error: got : ./include/linux/rcupdate.h:1077:9: error: Expected ; at end of statement ./include/linux/rcupdate.h:1077:9: error: got __flags ./include/linux/key.h:453:16: error: typename in expression ./include/linux/key.h:453:16: error: Expected ) in function call ./include/linux/key.h:453:16: error: got : ./include/linux/list_bl.h:74:33: error: typename in expression ./include/linux/list_bl.h:74:33: error: Expected ) in function call ./include/linux/list_bl.h:74:33: error: got : ./include/linux/rculist_bl.h:24:33: error: typename in expression ./include/linux/rculist_bl.h:24:33: error: Expected ) in function call ./include/linux/rculist_bl.h:24:33: error: got : ./include/linux/seqlock.h:259:16: error: typename in expression ./include/linux/seqlock.h:259:16: error: Expected ) in function call ./include/linux/seqlock.h:259:16: error: got : ./include/linux/seqlock.h:274:1: error: typename in expression ./include/linux/seqlock.h:274:1: error: Expected ) in function call ./include/linux/seqlock.h:274:1: error: got : ./include/linux/seqlock.h:274:1: error: typename in expression ./include/linux/seqlock.h:274:1: error: Expected ) in function call ./include/linux/seqlock.h:274:1: error: got : ./include/linux/seqlock.h:275:1: error: typename in expression ./include/linux/seqlock.h:275:1: error: Expected ) in function call ./include/linux/seqlock.h:275:1: error: got : ./include/linux/seqlock.h:275:1: error: typename in expression ./include/linux/seqlock.h:275:1: error: Expected ) in function call ./include/linux/seqlock.h:275:1: error: got : ./include/linux/seqlock.h:276:1: error: typename in expression ./include/linux/seqlock.h:276:1: error: Expected ) in function call ./include/linux/seqlock.h:276:1: error: got : ./include/linux/seqlock.h:276:1: error: typename in expression ./include/linux/seqlock.h:276:1: error: Expected ) in function call ./include/linux/seqlock.h:276:1: error: got : ./include/linux/seqlock.h:277:1: error: typename in expression ./include/linux/seqlock.h:277:1: error: Expected ) in function call ./include/linux/seqlock.h:277:1: error: got : ./include/linux/seqlock.h:277:1: error: typename in expression ./include/linux/seqlock.h:277:1: error: Expected ) in function call ./include/linux/seqlock.h:277:1: error: got : ./include/linux/seqlock.h:429:16: error: typename in expression ./include/linux/seqlock.h:429:16: error: Expected ) in function call ./include/linux/seqlock.h:429:16: error: got : ./include/linux/seqlock.h:682:16: error: typename in expression ./include/linux/seqlock.h:682:16: error: Expected ) in function call ./include/linux/seqlock.h:682:16: error: too many errors Segmentation fault (core dumped) make[3]: *** [scripts/Makefile.build:251: security/landlock/setup.o] Error 139 make[2]: *** [scripts/Makefile.build:502: security/landlock] Error 2 make[1]: *** [scripts/Makefile.build:502: security] Error 2 make: *** [Makefile:1994: .] Error 2 Please tell me if you need some more info. regards, Konstantin
regards, dan carpenter .