Thread (18 messages) flat view 18 messages, 4 authors, 2022-06-16

Re: [RFC PATCH 4/6] pkeys: Lift pkey hardware check for pkey_alloc()

From: Sohil Mehta <hidden>
Date: 2022-06-16 19:31:15
Also in: linux-kselftest, linux-mm, linuxppc-dev, lkml

quoted hunk ↗ jump to hunk
diff --git a/mm/mprotect.c b/mm/mprotect.c
index ba5592655ee3..56d35de33725 100644
--- a/mm/mprotect.c
+++ b/mm/mprotect.c
@@ -773,6 +773,9 @@ SYSCALL_DEFINE2(pkey_alloc, unsigned long, flags, unsigned long, init_val)
  	int pkey;
  	int ret;
  
+	if (!arch_pkeys_enabled())
+		return -ENOSPC;
+
See comments in patch 3/6. Since we are modifying (fixing) old behavior, 
should we just return ENOSYS to make this consistent?

Sohil
  	/* No flags supported yet. */
  	if (flags)
  		return -EINVAL;
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help