Re: [PATCH 1/8] signal: Make SIGKILL during coredumps an explicit special case
flat view
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2022-01-11 19:20:20
Also in:
linux-arch, lkml
Possibly related (same subject, not in this thread)
- 2022-01-26 · Re: [PATCH 1/8] signal: Make SIGKILL during coredumps an explicit special case · Olivier Langlois <hidden>
- 2022-01-18 · Re: [PATCH 1/8] signal: Make SIGKILL during coredumps an explicit special case · Dmitry Osipenko <digetx@gmail.com>
- 2022-01-18 · Re: [PATCH 1/8] signal: Make SIGKILL during coredumps an explicit special case · Eric W. Biederman <hidden>
- 2022-01-18 · Re: [PATCH 1/8] signal: Make SIGKILL during coredumps an explicit special case · Dmitry Osipenko <digetx@gmail.com>
- 2022-01-17 · Re: [PATCH 1/8] signal: Make SIGKILL during coredumps an explicit special case · Eric W. Biederman <hidden>
On Tue, Jan 11, 2022 at 10:51 AM Eric W. Biederman [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+ while ((n == -ERESTARTSYS) && test_thread_flag(TIF_NOTIFY_SIGNAL)) { + tracehook_notify_signal(); + n = __kernel_write(file, addr, nr, &pos); + }
This reads horribly wrongly to me.
That "tracehook_notify_signal()" thing *has* to be renamed before we
have anything like this that otherwise looks like "this will just loop
forever".
I'm pretty sure we've discussed that "tracehook" thing before - the
whole header file is misnamed, and most of the functions in theer are
too.
As an ugly alternative, open-code it, so that it's clear that "yup,
that clears the TIF_NOTIFY_SIGNAL flag".
Linus