Thread (19 messages) 19 messages, 4 authors, 2021-12-14

Re: [PATCH v3 2/3] block: don't delete queue kobject before its children

From: Bart Van Assche <bvanassche@acm.org>
Date: 2021-12-09 23:26:37
Also in: linux-block, linux-mmc, linux-scsi, lkml

On 12/9/21 3:17 PM, Eric Biggers wrote:
On Thu, Dec 09, 2021 at 02:38:02PM -0800, Bart Van Assche wrote:
quoted
On 12/7/21 5:35 PM, Eric Biggers wrote:
quoted
+	/* Now that all child objects were deleted, the queue can be deleted. */
Shouldn't the present tense be used above (were -> are)? Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
"deleted" is an action here, not a state.  I think it's fine as-is, but maybe
you would prefer the following?

	/* Now that we've deleted all child objects, we can delete the queue. */
Both alternatives work for me.

Thanks,

Bart.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help