Thread (11 messages) flat view 11 messages, 3 authors, 2021-08-19

Re: [PATCH 2/4] futex2: Implement vectorized wait

From: Peter Zijlstra <peterz@infradead.org>
Date: 2021-08-18 16:22:51
Also in: lkml

On Wed, Aug 18, 2021 at 01:00:57PM +0200, Thomas Gleixner wrote:
quoted
+/**
+ * struct futex_waitv - A waiter for vectorized wait
+ * @val:   Expected value at uaddr
+ * @uaddr: User address to wait on
+ * @flags: Flags for this waiter
+ */
+struct futex_waitv {
+	__u64 val;
Again. Why u64?
So I think the idea was that if we're going to do new syscalls, we
should cater for future extentions, one of which was 64bit futexes (for
64bit archs) (along with u{8,16,32})

The previous set of patches implemented a more complete replacement ABI
-- which I rather liked, however the implementation was completely
disjoint from the existing futexes, which was a non-starter for me.

Anyway, yes, current futexes are u32, but if we want to ever do u64
futexes, we should either do this syscall with a u64, or already plan to
retire the whole syscall.

Obiously this would've made good Changelog material, but alas it wasn't
there.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help