Re: [PATCH v3 1/2] mm: introduce process_mrelease system call

Started by Michal Hocko on Jul 23, 2021 · 2 messages from 2 authors · Last reply Jul 23, 2021

open the first message on its own page

Michal Hocko

Message details and related content
Open message details and related content
On Thu 22-07-21 21:47:56, Suren Baghdasaryan wrote:
On Thu, Jul 22, 2021, 7:04 PM Shakeel Butt [off-list ref] wrote:
quoted
On Thu, Jul 22, 2021 at 6:14 PM Suren Baghdasaryan [off-list ref]
wrote:
quoted
[...]
quoted
+
+       mmap_read_lock(mm);
How about mmap_read_trylock(mm) and return -EAGAIN on failure?
That sounds like a good idea. Thanks! I'll add that in the next respin.
Why is that a good idea? Can you do anything meaningful about the
failure other than immediately retry the syscall and hope for the best?

-- 
Michal Hocko
SUSE Labs

Shakeel Butt replied to Michal Hocko

Message details and related content
Open message details and related content
On Thu, Jul 22, 2021 at 11:20 PM Michal Hocko [off-list ref] wrote:
On Thu 22-07-21 21:47:56, Suren Baghdasaryan wrote:
quoted
On Thu, Jul 22, 2021, 7:04 PM Shakeel Butt [off-list ref] wrote:
quoted
On Thu, Jul 22, 2021 at 6:14 PM Suren Baghdasaryan [off-list ref]
wrote:
quoted
[...]
quoted
+
+       mmap_read_lock(mm);
How about mmap_read_trylock(mm) and return -EAGAIN on failure?
That sounds like a good idea. Thanks! I'll add that in the next respin.
Why is that a good idea? Can you do anything meaningful about the
failure other than immediately retry the syscall and hope for the best?
Yes we can. Based on the situation/impact we can select more victims.
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help