Re: [PATCH v2 00/14] genirq: Cleanup the usage of irq_set_affinity_hint

From
Nitesh Lal <hidden>
Date
2021-07-12 21:27:23
Also in
linux-pci, linux-scsi, lkml, netdev
Reply to
Leon Romanovsky, 2021-07-11
Hi Leon,

On Sun, Jul 11, 2021 at 7:32 AM Leon Romanovsky [off-list ref] wrote:
On Thu, Jul 08, 2021 at 03:24:20PM -0400, Nitesh Lal wrote:
quoted
On Tue, Jun 29, 2021 at 11:28 AM Nitesh Narayan Lal [off-list ref] wrote:
<...>
quoted
quoted

 drivers/infiniband/hw/i40iw/i40iw_main.c      |  4 +-
 drivers/mailbox/bcm-flexrm-mailbox.c          |  4 +-
 drivers/net/ethernet/cisco/enic/enic_main.c   |  8 +--
 drivers/net/ethernet/emulex/benet/be_main.c   |  4 +-
 drivers/net/ethernet/huawei/hinic/hinic_rx.c  |  4 +-
 drivers/net/ethernet/intel/i40e/i40e_main.c   |  8 +--
 drivers/net/ethernet/intel/iavf/iavf_main.c   |  8 +--
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 ++--
 drivers/net/ethernet/mellanox/mlx4/eq.c       |  8 ++-
 .../net/ethernet/mellanox/mlx5/core/pci_irq.c |  6 +--
 drivers/scsi/lpfc/lpfc_init.c                 |  4 +-
 drivers/scsi/megaraid/megaraid_sas_base.c     | 27 +++++-----
 drivers/scsi/mpt3sas/mpt3sas_base.c           | 21 ++++----
 include/linux/interrupt.h                     | 53 ++++++++++++++++++-
 kernel/irq/manage.c                           |  8 +--
 15 files changed, 113 insertions(+), 64 deletions(-)

--
Gentle ping.
Any comments or suggestions on any of the patches included in this series?
Please wait for -rc1, rebase and resend.
At least i40iw was deleted during merge window.
In -rc1 some non-trivial mlx5 changes also went in.  I was going through
these changes and it seems after your patch

e4e3f24b822f: ("net/mlx5: Provide cpumask at EQ creation phase")

we do want to control the affinity for the mlx5 interrupts from the driver.
Is that correct? This would mean that we should use
irq_set_affinity_and_hint() instead
of irq_update_affinity_hint().

-- 
Thanks
Nitesh
Thread (21 messages) 21 messages, 4 authors, last reply 2021-07-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help