Re: [PATCH v4 04/10] userfaultfd/shmem: support minor fault registration for shmem

From
Peter Xu <peterx@redhat.com>
Date
2021-04-27 15:57:20
Also in
linux-fsdevel, linux-kselftest, linux-mm, lkml
Reply to
Hugh Dickins, 2021-04-27
On Mon, Apr 26, 2021 at 07:23:57PM -0700, Hugh Dickins wrote:
On Tue, 20 Apr 2021, Axel Rasmussen wrote:
quoted
This patch allows shmem-backed VMAs to be registered for minor faults.
Minor faults are appropriately relayed to userspace in the fault path,
for VMAs with the relevant flag.

This commit doesn't hook up the UFFDIO_CONTINUE ioctl for shmem-backed
minor faults, though, so userspace doesn't yet have a way to resolve
such faults.

Acked-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Axel Rasmussen <axelrasmussen@google.com>
And if this "04/10" had been numbered 03/10, I would have said
Acked-by: Hugh Dickins <hughd@google.com>

Just read the comment above: "so userspace doesn't yet have a way to
resolve such faults" - if it doesn't by this stage, we're in trouble.
Right, so merging the two patches might be easier.  Even if we don't merge
them, we'll need to touch up the commit message since at least above paragraph
is not true anymore as we've already have UFFDIO_CONTINUE.  Thanks,

-- 
Peter Xu
Thread (28 messages) 28 messages, 3 authors, last reply 2021-04-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help