Re: [PATCH 1/2] pidfd_create(): remove static qualifier and declare pidfd_create() in linux/pid.h
From: Jan Kara <jack@suse.cz>
Date: 2021-04-19 10:13:41
Also in:
linux-fsdevel
On Fri 16-04-21 09:22:09, Matthew Bobrowski wrote:
With the idea to have fanotify(7) return pidfds within a `struct fanotify_event_metadata`, pidfd_create()'s scope is to increased so that it can be called from other subsystems within the Linux kernel. The current `static` qualifier from its definition is to be removed and a new function declaration for pidfd_create() is to be added to the linux/pid.h header file. Signed-off-by: Matthew Bobrowski <repnop@google.com>
I'm fine with this but it would be good to get explicit Christian's ack on this patch (I know he's already agreed with the intent in general). Honza
quoted hunk ↗ jump to hunk
--- include/linux/pid.h | 1 + kernel/pid.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)diff --git a/include/linux/pid.h b/include/linux/pid.h index fa10acb8d6a4..af308e15f174 100644 --- a/include/linux/pid.h +++ b/include/linux/pid.h@@ -78,6 +78,7 @@ struct file; extern struct pid *pidfd_pid(const struct file *file); struct pid *pidfd_get_pid(unsigned int fd, unsigned int *flags); +int pidfd_create(struct pid *pid, unsigned int flags); static inline struct pid *get_pid(struct pid *pid) {diff --git a/kernel/pid.c b/kernel/pid.c index ebdf9c60cd0b..91c4b6891c15 100644 --- a/kernel/pid.c +++ b/kernel/pid.c@@ -553,7 +553,7 @@ struct pid *pidfd_get_pid(unsigned int fd, unsigned int *flags) * Return: On success, a cloexec pidfd is returned. * On error, a negative errno number will be returned. */ -static int pidfd_create(struct pid *pid, unsigned int flags) +int pidfd_create(struct pid *pid, unsigned int flags) { int fd;-- 2.31.1.368.gbe11c130af-goog /M
-- Jan Kara [off-list ref] SUSE Labs, CR