Re: [PATCH 0/9] userfaultfd: add minor fault handling for shmem
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2021-04-09 05:04:50
Also in:
linux-fsdevel, linux-kselftest, linux-mm, lkml
On Thu, 8 Apr 2021 16:43:18 -0700 Axel Rasmussen [off-list ref] wrote:
The idea is that it will apply cleanly to akpm's tree, *replacing* the following patches (i.e., drop these first, and then apply this series): userfaultfd-support-minor-fault-handling-for-shmem.patch userfaultfd-support-minor-fault-handling-for-shmem-fix.patch userfaultfd-support-minor-fault-handling-for-shmem-fix-2.patch userfaultfd-support-minor-fault-handling-for-shmem-fix-3.patch userfaultfd-support-minor-fault-handling-for-shmem-fix-4.patch userfaultfd-selftests-use-memfd_create-for-shmem-test-type.patch userfaultfd-selftests-create-alias-mappings-in-the-shmem-test.patch userfaultfd-selftests-reinitialize-test-context-in-each-test.patch userfaultfd-selftests-exercise-minor-fault-handling-shmem-support.patch
Well. the problem is,
+ if (area_alias == MAP_FAILED)
+ err("mmap of memfd alias failed");`err' doesn't exist until eleventy patches later, in Peter's "userfaultfd/selftests: unify error handling". I got tired of (and lost confidence in) replacing "err(...)" with "fprintf(stderr, ...); exit(1)" everywhere then fixing up the fallout when Peter's patch came along. Shudder. Sorry, all this material pretty clearly isn't going to make 5.12 (potentially nine days hence), so I shall drop all the userfaultfd patches. Let's take a fresh run at all of this after -rc1. I have tentatively retained the first series: userfaultfd-add-minor-fault-registration-mode.patch userfaultfd-add-minor-fault-registration-mode-fix.patch userfaultfd-disable-huge-pmd-sharing-for-minor-registered-vmas.patch userfaultfd-hugetlbfs-only-compile-uffd-helpers-if-config-enabled.patch userfaultfd-add-uffdio_continue-ioctl.patch userfaultfd-update-documentation-to-describe-minor-fault-handling.patch userfaultfd-selftests-add-test-exercising-minor-fault-handling.patch but I don't believe they have had much testing standalone, without the other userfaultfd patches present. So I don't think it's smart to upstream these in this cycle. Or I could drop them so you and Peter can have a clean shot at redoing the whole thing. Please let me know.