[PATCH] lightnvm: remove duplicate include in lightnvm.h

Subsystems: the rest

STALE1942d

2 messages, 2 authors, 2021-04-13 · open the first message on its own page

[PATCH] lightnvm: remove duplicate include in lightnvm.h

From: <hidden>
Date: 2021-03-13 11:23:28

From: Zhang Yunkai <redacted>

'linux/ioctl.h' included in 'lightnvm.h' is duplicated.
It is also included in the 33th line.

Signed-off-by: Zhang Yunkai <redacted>
---
 include/uapi/linux/lightnvm.h | 1 -
 1 file changed, 1 deletion(-)
diff --git a/include/uapi/linux/lightnvm.h b/include/uapi/linux/lightnvm.h
index ead2e72e5c88..2745afd9b8fa 100644
--- a/include/uapi/linux/lightnvm.h
+++ b/include/uapi/linux/lightnvm.h
@@ -22,7 +22,6 @@
 
 #ifdef __KERNEL__
 #include <linux/const.h>
-#include <linux/ioctl.h>
 #else /* __KERNEL__ */
 #include <stdio.h>
 #include <sys/ioctl.h>
-- 
2.25.1

Re: [PATCH] lightnvm: remove duplicate include in lightnvm.h

From: Matias Bjørling <hidden>
Date: 2021-04-13 10:55:45

On 13/03/2021 12.22, menglong8.dong@gmail.com wrote:
quoted hunk
From: Zhang Yunkai <redacted>

'linux/ioctl.h' included in 'lightnvm.h' is duplicated.
It is also included in the 33th line.

Signed-off-by: Zhang Yunkai <redacted>
---
  include/uapi/linux/lightnvm.h | 1 -
  1 file changed, 1 deletion(-)
diff --git a/include/uapi/linux/lightnvm.h b/include/uapi/linux/lightnvm.h
index ead2e72e5c88..2745afd9b8fa 100644
--- a/include/uapi/linux/lightnvm.h
+++ b/include/uapi/linux/lightnvm.h
@@ -22,7 +22,6 @@
  
  #ifdef __KERNEL__
  #include <linux/const.h>
-#include <linux/ioctl.h>
  #else /* __KERNEL__ */
  #include <stdio.h>
  #include <sys/ioctl.h>
Thanks, Yunkai. I've pulled it. Note that I've merged your two patches 
into one.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help