Re: [PATCH v2 0/2] unprivileged fanotify listener
flat view
From: Amir Goldstein <amir73il@gmail.com>
Date: 2021-03-20 12:58:04
Also in:
linux-fsdevel
quoted
quoted
The code that sits in linux-next can give you pretty much a drop-in replacement of inotify and nothing more. See example code: https://github.com/amir73il/inotify-tools/commits/fanotify_name_fidThis is really great. Thank you for doing that work this will help quite a lot of use-cases and make things way simpler. I created a TODO to port our path-hotplug to this once this feature lands.FWIW, I just tried to build this branch on Ubuntu 20.04.2 with LTS kernel and there were some build issues, so rebased my branch on upstream inotify-tools to fix those build issues. I was not aware that the inotify-tools project is alive, I never intended to upstream this demo code and never created a github pull request but rebasing on upstream brought in some CI scripts, when I pushed the branch to my github it triggered some tests that reported build failures on Ubuntu 16.04 and 18.04. Anyway, there is a pre-rebase branch 'fanotify_name' and the post rebase branch 'fanotify_name_fid'. You can try whichever works for you. You can look at the test script src/test_demo.sh for usage example. Or just cd into a writable directory and run the script to see the demo. The demo determines whether to use a recursive watch or "global" watch by the uid of the user.quoted
quoted
quoted
quoted
If you think that is useful and you want to play with this feature I can provide a WIP branch soon.I would like to first play with the support for unprivileged fanotify but sure, it does sound useful!Just so you have an idea what I am talking about, this is a very early POC branch: https://github.com/amir73il/linux/commits/fanotify_usernsThanks! I'll try to pull this and take a look next week. I hope that's ok.Fine. I'm curious to know what it does. Did not get to test it with userns yet :)
Now tested FAN_MARK_FILESYSTEM watch on tmpfs mounted
inside userns and works fine, with two wrinkles I needed to iron:
1. FAN_REPORT_FID not supported on tmpfs because tmpfs has
zero f_fsid (easy to fix)
2. open_by_handle_at() is not userns aware (can relax for
FS_USERNS_MOUNT fs)
Pushed these two fixes to branch fanotify_userns.
Thanks,
Amir.