Re: epoll_wait.2: epoll_pwait2(2) prototype

Hi Alex,

On Sat, Mar 13, 2021 at 05:48:08PM +0100, Alejandro Colomar (man-pages) wrote:

Hi Willem,

I checked that the prototype of the kernel epoll_pwait2() syscall is 
different from the one we recently merged; it has one more parameter 
'size_t sigsetsize':

$ grep_syscall epoll_pwait2
fs/eventpoll.c:2272:
SYSCALL_DEFINE6(epoll_pwait2, int, epfd, struct epoll_event __user *, 
events,
		int, maxevents, const struct __kernel_timespec __user *, timeout,
		const sigset_t __user *, sigmask, size_t, sigsetsize)
fs/eventpoll.c:2326:
COMPAT_SYSCALL_DEFINE6(epoll_pwait2, int, epfd,
		       struct epoll_event __user *, events,
		       int, maxevents,
		       const struct __kernel_timespec __user *, timeout,
		       const compat_sigset_t __user *, sigmask,
		       compat_size_t, sigsetsize)
include/linux/compat.h:540:
asmlinkage long compat_sys_epoll_pwait2(int epfd,
			struct epoll_event __user *events,
			int maxevents,
			const struct __kernel_timespec __user *timeout,
			const compat_sigset_t __user *sigmask,
			compat_size_t sigsetsize);
include/linux/syscalls.h:389:
asmlinkage long sys_epoll_pwait2(int epfd, struct epoll_event __user 
*events,
				 int maxevents,
				 const struct __kernel_timespec __user *timeout,
				 const sigset_t __user *sigmask,
				 size_t sigsetsize);

I'm could fix the prototype, but maybe there are more changes needed for 
the manual page.

Would you mind fixing it?

Looks like the 6th argument of epoll_pwait and epoll_pwait2 syscalls
is already described in "C library/kernel differences" subsection of
epoll_pwait2(2).


-- 
ldv