Re: [PATCH v5 1/2] tpm: add sysfs exports for all banks of PCR registers
From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: 2021-01-15 18:08:33
Also in:
linux-integrity
On Fri, 2021-01-15 at 09:26 -0800, James Bottomley wrote:
On Fri, 2021-01-15 at 14:54 +0100, Greg KH wrote:quoted
On Thu, Jan 14, 2021 at 04:21:08PM -0800, James Bottomley wrote:[...]quoted
quoted
It looks like we already have a couple of bugs in the kernel introduced by this confusion ... return sysfs_emit() vs return sysfs_emit_at() being the most tricky ...Hm, Joe, you did the conversion to these functions (and wrote the api), care to review this?A cursory glance tells me that summary_show in drivers/infiniband/hw/usnic/usnic_ib_sysfs.c has a problem, I think the last = should be +=
The use in drivers/base/node.c:node_read_meminfo() is highly questionable. While currently not emitting wrong code, it depends on len being 0 when passed in to sysfs_emit_at(). That argues it should either be using sysfs_emit() or it should have a len += just in case something gets prepended that makes len non zero. James