On Mon, Nov 16, 2020 at 5:23 PM Christoph Hellwig [off-list ref] wrote:

On Thu, Nov 12, 2020 at 04:56:57PM -0500, Tal Zussman wrote:

quoted

The relevant syscalls were previously moved from kernel/timer.c to kernel/sys.c,
but the comments weren't updated to reflect this change.

Fixing these comments messes up the alphabetical ordering of syscalls by
filename. This could be fixed by merging the two groups of kernel/sys.c syscalls,
but that would require reordering the syscalls and renumbering them to maintain
the numerical order in unistd.h.

Lots of overly long lines in your commit log.

As for the patch itself:  IMHO we should just remove the comments
about the files as that information is completely irrelevant.

I noticed I already applied the patch last week to the asm-generic cleanups
branch, but forgot to send out the email about it.

I do agree the file names are rather useless, and I would apply a follow-up
patch to completely remove them as well. My real plan was to remove
the file itself and replace it with the parsable syscall.tbl format that we
use for all non-generic architectures, but I haven't gotten around to updating
the patch that Firoz Khan did a long time ago.

      arnd