Re: [PATCH v22 01/12] landlock: Add object management

On Thu, Oct 29, 2020 at 10:30 AM Mickaël Salaün [off-list ref] wrote:

On 29/10/2020 02:05, Jann Horn wrote:

quoted

On Tue, Oct 27, 2020 at 9:04 PM Mickaël Salaün [off-list ref] wrote:

quoted

A Landlock object enables to identify a kernel object (e.g. an inode).
A Landlock rule is a set of access rights allowed on an object.  Rules
are grouped in rulesets that may be tied to a set of processes (i.e.
subjects) to enforce a scoped access-control (i.e. a domain).

[...]

quoted

quoted

diff --git a/security/landlock/object.c b/security/landlock/object.c

[...]

quoted

+void landlock_put_object(struct landlock_object *const object)
+{
+       /*
+        * The call to @object->underops->release(object) might sleep e.g.,

s/ e.g.,/, e.g./

I indeed prefer the comma preceding the "e.g.", but it seems that there
is a difference between UK english and US english:
https://english.stackexchange.com/questions/16172/should-i-always-use-a-comma-after-e-g-or-i-e
Looking at the kernel documentation makes it clear:
$ git grep -F 'e.g. ' | wc -l
1179
$ git grep -F 'e.g., ' | wc -l
160

I'll apply your fix in the whole patch series.

Ooh, sorry. I didn't realize that that's valid in UK English...