Re: [PATCH v11 9/9] x86: Disallow vsyscall emulation when CET is enabled

From
Yu, Yu-cheng <hidden>
Date
2020-08-25 15:09:00
Also in
linux-arch, linux-doc, linux-mm, lkml
Reply to
Florian Weimer, 2020-08-25
On 8/25/2020 2:14 AM, Florian Weimer wrote:
* Andy Lutomirski:
quoted
On Mon, Aug 24, 2020 at 5:30 PM Yu-cheng Yu [off-list ref] wrote:
quoted
From: "H.J. Lu" <redacted>

Emulation of the legacy vsyscall page is required by some programs built
before 2013.  Newer programs after 2013 don't use it.  Disallow vsyscall
emulation when Control-flow Enforcement (CET) is enabled to enhance
security.
NAK.

By all means disable execute emulation if CET-IBT is enabled at the
time emulation is attempted, and maybe even disable the vsyscall page
entirely if you can magically tell that CET-IBT will be enabled when a
process starts, but you don't get to just disable it outright on a
CET-enabled kernel.
Yeah, we definitely would have to revert/avoid this downstream.  People
definitely want to run glibc-2.12-era workloads on current kernels.
Thanks for catching it.
That makes sense.  I will update the patch.

Thanks,
Yu-cheng
Thread (2 messages) 2 messages, 2 authors, last reply 2020-08-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help