Thread (30 messages) 30 messages, 3 authors, 2020-08-25

Re: [PATCH v5 7/9] btrfs: optionally extend i_size in cow_file_range_inline()

From: Josef Bacik <josef@toxicpanda.com>
Date: 2020-08-24 19:33:26
Also in: linux-btrfs, linux-fsdevel

On 8/21/20 3:38 AM, Omar Sandoval wrote:
From: Omar Sandoval <redacted>

Currently, an inline extent is always created after i_size is extended
from btrfs_dirty_pages(). However, for encoded writes, we only want to
update i_size after we successfully created the inline extent. Add an
update_i_size parameter to cow_file_range_inline() and
insert_inline_extent() and pass in the size of the extent rather than
determining it from i_size. Since the start parameter is always passed
as 0, get rid of it and simplify the logic in these two functions. While
we're here, let's document the requirements for creating an inline
extent.

Signed-off-by: Omar Sandoval <redacted>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help