Thread (12 messages) flat view 12 messages, 2 authors, 2020-07-20

Re: [net-next PATCH v3 1/7] hsr: enhance netlink socket interface to support PRP

From: David Miller <davem@davemloft.net>
Date: 2020-07-18 01:56:13
Also in: lkml, netdev

From: Murali Karicheri <redacted>
Date: Fri, 17 Jul 2020 11:15:05 -0400
quoted hunk ↗ jump to hunk
@@ -32,7 +33,9 @@ static int hsr_newlink(struct net *src_net, struct net_device *dev,
 		       struct netlink_ext_ack *extack)
 {
 	struct net_device *link[2];
-	unsigned char multicast_spec, hsr_version;
+	unsigned char multicast_spec;
+	enum hsr_version proto_version;
+	u8 proto = HSR_PROTOCOL_HSR;
Please use reverse christmas tree ordering for local variables.

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help