On Tue, Jul 07, 2020 at 01:49:23PM +0200, Christian Brauner wrote:

On Mon, Jul 06, 2020 at 01:17:16PM -0700, Kees Cook wrote:

quoted

For both pidfd and seccomp, the __user pointer is not used. Update
__receive_fd() to make writing to ufd optional via a NULL check. However,
for the receive_fd_user() wrapper, ufd is NULL checked so an -EFAULT
can be returned to avoid changing the SCM_RIGHTS interface behavior. Add
new wrapper receive_fd() for pidfd and seccomp that does not use the ufd
argument. For the new helper, the allocated fd needs to be returned on
success. Update the existing callers to handle it.

Reviewed-by: Sargun Dhillon <redacted>
Signed-off-by: Kees Cook <redacted>
---

Hm, I'm not sure why 2/7 and 3/7 aren't just one patch but ok. :)

I wanted to do a "clean" move from one source to another without any
behavioral changes first.

Acked-by: Christian Brauner <redacted>

Thanks!

-- 
Kees Cook