Re: [PATCH 3/3] selftests: add readfile(2) selftests

Hi Greg,

On Sun, Jul 5, 2020 at 8:55 AM Greg Kroah-Hartman
[off-list ref] wrote:

On Sat, Jul 04, 2020 at 08:38:26PM +0200, Geert Uytterhoeven wrote:

quoted

On Sat, Jul 4, 2020 at 4:05 PM Greg Kroah-Hartman
[off-list ref] wrote:

quoted

Test the functionality of readfile(2) in various ways.

Also provide a simple speed test program to benchmark using readfile()
instead of using open()/read()/close().

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

quoted

quoted

--- /dev/null
+++ b/tools/testing/selftests/readfile/readfile.c

quoted

+static void readfile(const char *filename)
+{
+//     int root_fd;

???

Ugh, sorry about that, I obviously didn't clean up my last tests from
this file, thanks for catching that.

Reading about seq_file behavior, did the commented-out test for
"/sys/kernel/debug/usb/devices" work?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds