Re: [PATCH 1/3] glibc: Perform rseq registration at C startup and thread creation (v21)

* Mathieu Desnoyers:

quoted

I think we should keep things simple on the glibc side for now and do
this changes to the kernel headers first.

Just to be sure I understand what you mean by "keep things simple", do you
recommend removing the following lines completely for now from sys/rseq.h ?

/* Ensure the compiler supports rseq_align.  */
__rseq_static_assert (__rseq_alignof (struct rseq_cs) >= 32, "alignment");
__rseq_static_assert (__rseq_alignof (struct rseq) >= 32, "alignment");

Yes, that's what I meant.

Thanks,
Florian

----- On Jun 24, 2020, at 3:24 PM, Florian Weimer fweimer@redhat.com wrote:

* Mathieu Desnoyers:

quoted

quoted

I think we should keep things simple on the glibc side for now and do
this changes to the kernel headers first.

Just to be sure I understand what you mean by "keep things simple", do you
recommend removing the following lines completely for now from sys/rseq.h ?

/* Ensure the compiler supports rseq_align.  */
__rseq_static_assert (__rseq_alignof (struct rseq_cs) >= 32, "alignment");
__rseq_static_assert (__rseq_alignof (struct rseq) >= 32, "alignment");

Yes, that's what I meant.

Agreed, I queued this change for my next round.

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com