On Tue, Jun 16, 2020 at 05:29:41AM +0000, Sargun Dhillon wrote:

On Mon, Jun 15, 2020 at 08:25:15PM -0700, Kees Cook wrote:

quoted

+/**
+ * __fd_install_received() - Install received file into file descriptor table
+ *
+ * @fd: fd to install into (if negative, a new fd will be allocated)
+ * @file: struct file that was received from another process
+ * @ufd_required: true to use @ufd for writing fd number to userspace
+ * @ufd: __user pointer to write new fd number to
+ * @o_flags: the O_* flags to apply to the new fd entry

Probably doesn't matter, but this function doesn't take the fd, or ufd_required
argument in this patch. 

quoted

+ *
+ * Installs a received file into the file descriptor table, with appropriate
+ * checks and count updates. Optionally writes the fd number to userspace.

ufd does not apppear options here.

Argh, yes, thanks. I think this was a fixup targeting the wrong commit.
I will adjust.

-- 
Kees Cook