Re: [PATCH v2] timens: show clock symbolic names in /proc/pid/timens_offsets

Hi Andrei,

On Thu, 16 Apr 2020 at 08:56, Andrei Vagin [off-list ref] wrote:

On Sat, Apr 11, 2020 at 08:40:31AM -0700, Andrei Vagin wrote:

quoted

Michael Kerrisk suggested to replace numeric clock IDs on symbolic
names.

Now the content of these files looks like this:
$ cat /proc/774/timens_offsets
monotonic      864000         0
boottime      1728000         0

For setting offsets, both representations of clocks can be used.

As for compatibility, it is acceptable to change things as long as
userspace doesn't care. The format of timens_offsets files is very
new and there are no userspace tools that rely on this format.

But three projects crun, util-linux and criu rely on the interface of
setting time offsets and this is why we need to continue supporting the
clock IDs in this case.

Fixes: 04a8682a71be ("fs/proc: Introduce /proc/pid/timens_offsets")
Cc: Thomas Gleixner <redacted>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Eric W. Biederman <redacted>
Cc: Dmitry Safonov <redacted>
Acked-by: Michael Kerrisk <redacted>

Thomas and Andrew, could you merge this patch? I am sorry, I used the
wrong subsystem prefix. Let me know if I need to send the third version
of this patch.

This patch should also be marked for stable@.

Thanks,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/