Re: [PATCH V10 08/11] fs/xfs: Combine xfs_diflags_to_linux() and xfs_diflags_to_iflags()
From: Dave Chinner <david@fromorbit.com>
Date: 2020-04-23 22:37:30
Also in:
linux-ext4, linux-fsdevel, linux-xfs, lkml
On Wed, Apr 22, 2020 at 02:20:59PM -0700, ira.weiny@intel.com wrote:
From: Ira Weiny <redacted> The functionality in xfs_diflags_to_linux() and xfs_diflags_to_iflags() are nearly identical. The only difference is that *_to_linux() is called after inode setup and disallows changing the DAX flag. Combining them can be done with a flag which indicates if this is the initial setup to allow the DAX flag to be properly set only at init time. So remove xfs_diflags_to_linux() and call the modified xfs_diflags_to_iflags() directly. While we are here simplify xfs_diflags_to_iflags() to take struct xfs_inode and use xfs_ip2xflags() to ensure future diflags are included correctly. Reviewed-by: Darrick J. Wong <redacted> Signed-off-by: Ira Weiny <redacted>
Looks good. Reviewed-by: Dave Chinner <redacted> -- Dave Chinner david@fromorbit.com