Thread (117 messages) 117 messages, 14 authors, 2020-03-07

Re: [PATCH 00/17] VFS: Filesystem information and notifications [ver #17]

From: Al Viro <viro@zeniv.linux.org.uk>
Date: 2020-03-06 20:38:55
Also in: linux-fsdevel, lkml

On Fri, Mar 06, 2020 at 08:37:05PM +0000, Al Viro wrote:
You are misreading mntput_no_expire(), BTW - your get_mount() can
bloody well race with umount(2), hitting the moment when we are done
figuring out whether it's busy but hadn't cleaned ->mnt_ns (let alone
set MNT_DOOMED) yet.  If somebody calls umount(2) on a filesystem that
is not mounted anywhere else, they are not supposed to see the sucker
return 0 until the filesystem is shut down.  You break that.
While we are at it, d_alloc_parallel() requires i_rwsem on parent held
at least shared.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help