Re: [PATCH 03/19] fsinfo: Provide a bitmap of supported features [ver #16]
From: David Howells <dhowells@redhat.com>
Date: 2020-02-20 12:22:17
Also in:
linux-fsdevel, lkml
From: David Howells <dhowells@redhat.com>
Date: 2020-02-20 12:22:17
Also in:
linux-fsdevel, lkml
Darrick J. Wong [off-list ref] wrote:
quoted
+struct fsinfo_features { + __u8 features[(FSINFO_FEAT__NR + 7) / 8];Hm...the structure size is pretty small (56 bytes) and will expand as we add new _FEAT flags. Is this ok because the fsinfo code will truncate its response to userspace to whatever buffer size userspace tells it?
Yes. Also, you can ask fsinfo how many feature bits it supports. I should put this in the struct first rather than putting it elsewhere. David