Thread (11 messages) 11 messages, 6 authors, 2019-12-21

Re: [PATCH v4 2/5] pid: Add PIDFD_IOCTL_GETFD to fetch file descriptors from processes

flat view

From: Andy Lutomirski <luto@kernel.org>
Date: 2019-12-20 01:43:35
Also in: linux-fsdevel, lkml

On Wed, Dec 18, 2019 at 3:55 PM Sargun Dhillon [off-list ref] wrote:
quoted hunk ↗ jump to hunk

+
+       if (!ptrace_may_access(task, PTRACE_MODE_READ_REALCREDS)) {
+               file = ERR_PTR(-EPERM);
+               goto out;
+       }
I don't think this is MODE_READ.  By copying an fd from the task, you
can easily change its state.

IMO it would be really nice if pidfd could act more like a capability
here and carry a ptrace mode, for example.  But I guess it doesn't
right now.


--Andy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help