Re: [PATCH v26 01/12] Linux Random Number Generator

Hi "Stephan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on v5.4-rc8 next-20191122]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Stephan-M-ller/dev-random-a-new-approach-with-full-SP800-90B/20191125-042152
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git b78cda795ac83333293f1bfa3165572a47e550c2
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:6:0,
                    from include/linux/kernel.h:15,
                    from include/asm-generic/bug.h:19,
                    from arch/sh/include/asm/bug.h:112,
                    from include/linux/bug.h:5,
                    from include/linux/mmdebug.h:5,
                    from include/linux/percpu.h:5,
                    from include/asm-generic/irq_regs.h:11,
                    from ./arch/sh/include/generated/asm/irq_regs.h:1,
                    from drivers/char/lrng/lrng_pool.c:10:

quoted

drivers/char/lrng/lrng_pool.c:216:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]

    core_initcall(lrng_init_time_source);
                  ^
   include/linux/init.h:197:50: note: in definition of macro '___define_initcall'
      __attribute__((__section__(#__sec ".init"))) = fn;
                                                     ^~
   include/linux/init.h:218:28: note: in expansion of macro '__define_initcall'
    #define core_initcall(fn)  __define_initcall(fn, 1)
                               ^~~~~~~~~~~~~~~~~

quoted

drivers/char/lrng/lrng_pool.c:216:1: note: in expansion of macro 'core_initcall'

    core_initcall(lrng_init_time_source);
    ^~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +216 drivers/char/lrng/lrng_pool.c

   215	
 > 216	core_initcall(lrng_init_time_source);
   217	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation