[PATCH 2/3] clone.2: Check for MAP_FAILED not NULL on mmap()
flat view
STALE2524d
From: Christian Brauner <christian@brauner.io>
Date: 2019-11-16 11:41:34
Also in:
linux-man, lkml
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Christian Brauner <redacted> If mmap() fails it will return MAP_FAILED which according to the manpage is (void *)-1 not NULL. Signed-off-by: Christian Brauner <redacted> --- man2/clone.2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man2/clone.2 b/man2/clone.2
index 57a9eaba7..faff2ada6 100644
--- a/man2/clone.2
+++ b/man2/clone.2@@ -1628,7 +1628,7 @@ main(int argc, char *argv[]) stack = mmap(NULL, STACK_SIZE, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS | MAP_STACK, \-1, 0); - if (stack == NULL) + if (stack == MAP_FAILED) errExit("mmap"); stackTop = stack + STACK_SIZE; /* Assume stack grows downward */
--
2.24.0