Thread (26 messages) 26 messages, 2 authors, 2019-12-05

Re: [RFC PATCH v3 03/12] fs: add RWF_ENCODED for reading/writing compressed data

flat view

From: Omar Sandoval <osandov@osandov.com>
Date: 2019-11-27 09:10:19
Also in: linux-btrfs, linux-fsdevel

On Wed, Nov 27, 2019 at 11:00:15AM +0200, Nikolay Borisov wrote:

On 26.11.19 г. 19:36 ч., Omar Sandoval wrote:
quoted
On Tue, Nov 26, 2019 at 03:53:02PM +0200, Nikolay Borisov wrote:
quoted

On 20.11.19 г. 20:24 ч., Omar Sandoval wrote:
quoted
From: Omar Sandoval <redacted>
<snip>
quoted
 
+enum {
+	ENCODED_IOV_COMPRESSION_NONE,
+#define ENCODED_IOV_COMPRESSION_NONE ENCODED_IOV_COMPRESSION_NONE
+	ENCODED_IOV_COMPRESSION_ZLIB,
+#define ENCODED_IOV_COMPRESSION_ZLIB ENCODED_IOV_COMPRESSION_ZLIB
+	ENCODED_IOV_COMPRESSION_LZO,
+#define ENCODED_IOV_COMPRESSION_LZO ENCODED_IOV_COMPRESSION_LZO
+	ENCODED_IOV_COMPRESSION_ZSTD,
+#define ENCODED_IOV_COMPRESSION_ZSTD ENCODED_IOV_COMPRESSION_ZSTD
+	ENCODED_IOV_COMPRESSION_TYPES = ENCODED_IOV_COMPRESSION_ZSTD,
This looks very dodgy, what am I missing?
This is a somewhat common trick so that enum values can be checked for
with ifdef/ifndef. See include/uapi/linux.in.h, for example.
I cannot seem to have this file on my system (or any .in.h file for that
matter in the kernel source dir).
Whoops, that should be include/uapi/linux/in.h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help