On 2019-8-3 1:31, Eric Biggers wrote:

On Fri, Aug 02, 2019 at 04:10:15PM +0800, Chao Yu wrote:

quoted

Hi Eric,

On 2019/7/27 6:41, Eric Biggers wrote:

quoted

From: Eric Biggers <redacted>

Wire up the new ioctls for adding and removing fscrypt keys to/from the
filesystem, and the new ioctl for retrieving v2 encryption policies.

FS_IOC_REMOVE_ENCRYPTION_KEY also required making f2fs_drop_inode() call
fscrypt_drop_inode().

For more details see Documentation/filesystems/fscrypt.rst and the
fscrypt patches that added the implementation of these ioctls.

Signed-off-by: Eric Biggers <redacted>

Reviewed-by: Chao Yu <redacted>

BTW, do you think it needs to make xxfs_has_support_encrypt() function be a
common interface defined in struct fscrypt_operations, as I see all
fscrypt_ioctl_*() needs to check with it, tho such cleanup is minor...

Maybe.  It would work nicely for ext4 and f2fs, but ubifs does things
differently since it automatically enables the encryption feature if needed.
So we'd have to make the callback optional.

Correct, ubifs can leave the callback as NULL function pointer.

In any case, I think this should be separate from this patchset.

Yup, it can be done in a separated patch if need.

Thanks,

- Eric


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel