Re: [PATCH V35 27/29] tracefs: Restrict tracefs when the kernel is locked down
flat view
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2019-07-16 23:14:45
Also in:
linux-security-module, lkml
On Mon, 15 Jul 2019 12:59:44 -0700 Matthew Garrett [off-list ref] wrote:
Tracefs may release more information about the kernel than desirable, so restrict it when the kernel is locked down in confidentiality mode by preventing open(). Signed-off-by: Matthew Garrett <redacted> Cc: Steven Rostedt <rostedt@goodmis.org> ---
quoted hunk ↗ jump to hunk
@@ -389,6 +414,7 @@ struct dentry *tracefs_create_file(const char *name, umode_t mode, { struct dentry *dentry; struct inode *inode; + struct file_operations *proxy_fops;
Small nit, but please add this as the first declaration, to keep the "upside-down x-mas tree" look. I know some of the other functions in this file don't follow that (which should be cleaned up some day), but I'd like to avoid adding more that breaks the aesthetic of the code.
quoted hunk ↗ jump to hunk
if (!(mode & S_IFMT)) mode |= S_IFREG;@@ -402,8 +428,18 @@ struct dentry *tracefs_create_file(const char *name, umode_t mode, if (unlikely(!inode)) return failed_creating(dentry); + proxy_fops = kzalloc(sizeof(struct file_operations), GFP_KERNEL); + if (!proxy_fops) + return failed_creating(dentry); + + if (fops)
I think you meant "if (!fops)". -- Steve
quoted hunk ↗ jump to hunk
+ fops = &tracefs_file_operations; + + dentry->d_fsdata = (void *)fops; + memcpy(proxy_fops, fops, sizeof(*proxy_fops)); + proxy_fops->open = default_open_file; inode->i_mode = mode; - inode->i_fop = fops ? fops : &tracefs_file_operations; + inode->i_fop = proxy_fops; inode->i_private = data; d_instantiate(dentry, inode); fsnotify_create(dentry->d_parent->d_inode, dentry);