Re: [PATCH v6 15/17] ext4: add fs-verity read support

From
Theodore Ts'o <tytso@mit.edu>
Date
2019-07-07 18:54:50
Also in
linux-ext4, linux-f2fs-devel, linux-fscrypt, linux-fsdevel, linux-integrity
Reply to
Eric Biggers, 2019-07-01
On Mon, Jul 01, 2019 at 08:32:35AM -0700, Eric Biggers wrote:
From: Eric Biggers <redacted>

Make ext4_mpage_readpages() verify data as it is read from fs-verity
files, using the helper functions from fs/verity/.

To support both encryption and verity simultaneously, this required
refactoring the decryption workflow into a generic "post-read
processing" workflow which can do decryption, verification, or both.

The case where the ext4 block size is not equal to the PAGE_SIZE is not
supported yet, since in that case ext4_mpage_readpages() sometimes falls
back to block_read_full_page(), which does not support fs-verity yet.

Co-developed-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Eric Biggers <redacted>
Looks good.  Since there's a S-o-B, some might claim that a
Reviewed-by: is not necessary, but to the extent that you modified
this code as well:

Reviewed-by: Theodore Ts'o <tytso@mit.edu>

							- Ted
Thread (24 messages) 24 messages, 3 authors, last reply 2019-07-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help