Thread (70 messages) 70 messages, 7 authors, 2019-06-15

Re: [PATCH v7 12/14] x86/vsyscall/64: Fixup shadow stack and branch tracking for vsyscall

From: Andy Lutomirski <luto@kernel.org>
Date: 2019-06-06 20:27:59
Also in: linux-arch, linux-doc, linux-mm, lkml

On Thu, Jun 6, 2019 at 1:17 PM Yu-cheng Yu [off-list ref] wrote:
quoted hunk ↗ jump to hunk
When emulating a RET, also unwind the task's shadow stack and cancel
the current branch tracking status.

Signed-off-by: Yu-cheng Yu <redacted>
---
 arch/x86/entry/vsyscall/vsyscall_64.c | 28 +++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
diff --git a/arch/x86/entry/vsyscall/vsyscall_64.c b/arch/x86/entry/vsyscall/vsyscall_64.c
index d9d81ad7a400..6869ef9d1e8b 100644
--- a/arch/x86/entry/vsyscall/vsyscall_64.c
+++ b/arch/x86/entry/vsyscall/vsyscall_64.c
@@ -38,6 +38,8 @@
 #include <asm/fixmap.h>
 #include <asm/traps.h>
 #include <asm/paravirt.h>
+#include <asm/fpu/xstate.h>
+#include <asm/fpu/types.h>

 #define CREATE_TRACE_POINTS
 #include "vsyscall_trace.h"
@@ -92,6 +94,30 @@ static int addr_to_vsyscall_nr(unsigned long addr)
        return nr;
 }

+void fixup_shstk(void)
+{
+#ifdef CONFIG_X86_INTEL_SHADOW_STACK_USER
+       u64 r;
+
+       if (current->thread.cet.shstk_enabled) {
+               rdmsrl(MSR_IA32_PL3_SSP, r);
+               wrmsrl(MSR_IA32_PL3_SSP, r + 8);
+       }
+#endif
+}
+
+void fixup_ibt(void)
+{
+#ifdef CONFIG_X86_INTEL_BRANCH_TRACKING_USER
+       u64 r;
+
+       if (current->thread.cet.ibt_enabled) {
+               rdmsrl(MSR_IA32_U_CET, r);
+               wrmsrl(MSR_IA32_U_CET, r & ~MSR_IA32_CET_WAIT_ENDBR);
+       }
+#endif
+}
These should be static.

But please just inline them directly in their one call site.  The code
will be a lot easier to understand.

--Andy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help