Re: [PATCH 03/25] vfs: Allow fsinfo() to query what's in an fs_context [ver #14]

From
Christian Brauner <christian@brauner.io>
Date
2019-06-26 10:06:14
Also in
linux-fsdevel, lkml
Reply to
David Howells, 2019-06-26
On Wed, Jun 26, 2019 at 11:02:59AM +0100, David Howells wrote:
Christian Brauner [off-list ref] wrote:
quoted
quoted
+	ret = mutex_lock_interruptible(&fc->uapi_mutex);
+	if (ret == 0) {
+		ret = -EIO;
Why EIO when there's no root dentry?
Because I don't want to use ENODATA/EBADF and preferably not EINVAL and
because the context you're accessing isn't in the correct state for you to be
able to do that.  How about EBADFD ("File descriptor in bad state")?
Do we have that? If so that sounds good.

Christian
Thread (45 messages) 45 messages, 3 authors, last reply 2019-06-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help