On May 20, 2019 2:39:46 AM PDT, Roberto Sassu [off-list ref] wrote:

On 5/18/2019 12:17 AM, Arvind Sankar wrote:

quoted

On Fri, May 17, 2019 at 02:47:31PM -0700, H. Peter Anvin wrote:

quoted

On 5/17/19 2:02 PM, Arvind Sankar wrote:

quoted

On Fri, May 17, 2019 at 01:18:11PM -0700, hpa@zytor.com wrote:

quoted

Ok... I just realized this does not work for a modular initramfs,

composed at load time from multiple files, which is a very real
problem. Should be easy enough to deal with: instead of one large file,
use one companion file per source file, perhaps something like
filename..xattrs (suggesting double dots to make it less likely to
conflict with a "real" file.) No leading dot, as it makes it more
likely that archivers will sort them before the file proper.

quoted

quoted

quoted

This version of the patch was changed from the previous one exactly

to deal with this case --

quoted

quoted

quoted

it allows for the bootloader to load multiple initramfs archives,

each

quoted

quoted

quoted

with its own .xattr-list file, and to have that work properly.
Could you elaborate on the issue that you see?

Well, for one thing, how do you define "cpio archive", each with its

own

quoted

quoted

.xattr-list file? Second, that would seem to depend on the ordering,

no,

quoted

quoted

in which case you depend critically on .xattr-list file following

the

quoted

quoted

files, which most archivers won't do.

Either way it seems cleaner to have this per file; especially if/as

it

quoted

quoted

can be done without actually mucking up the format.

I need to run, but I'll post a more detailed explanation of what I

did

quoted

quoted

in a little bit.

	-hpa

Not sure what you mean by how do I define it? Each cpio archive will
contain its own .xattr-list file with signatures for the files within
it, that was the idea.

You need to review the code more closely I think -- it does not

depend

quoted

on the .xattr-list file following the files to which it applies.

The code first extracts .xattr-list as though it was a regular file.

If

quoted

a later dupe shows up (presumably from a second archive, although the
patch will actually allow a second one in the same archive), it will
then process the existing .xattr-list file and apply the attributes
listed within it. It then will proceed to read the second one and
overwrite the first one with it (this is the normal behaviour in the
kernel cpio parser). At the end once all the archives have been
extracted, if there is an .xattr-list file in the rootfs it will be
parsed (it would've been the last one encountered, which hasn't been
parsed yet, just extracted).

Regarding the idea to use the high 16 bits of the mode field in
the header that's another possibility. It would just require

additional

quoted

support in the program that actually creates the archive though,

which

quoted

the current patch doesn't.

Yes, for adding signatures for a subset of files, no changes to the ram
disk generator are necessary. Everything is done by a custom module. To
support a generic use case, it would be necessary to modify the
generator to execute getfattr and the awk script after files have been
placed in the temporary directory.

If I understood the new proposal correctly, it would be task for cpio
to
read file metadata after the content and create a new record for each
file with mode 0x18000, type of metadata encoded in the file name and
metadata as file content. I don't know how easy it would be to modify
cpio. Probably the amount of changes would be reasonable.

The kernel will behave in a similar way. It will call do_readxattrs()
in
do_copy() for each file. Since the only difference between the current
and the new proposal would be two additional calls to do_readxattrs()
in
do_name() and unpack_to_rootfs(), maybe we could support both.

Roberto

The nice thing with explicit metadata is that it doesn't have to contain the filename per se, and each file is self-contained. There is a reason why each cpio header starts with the magic number: each cpio record is formally independent and can be processed in isolation.  The TRAILER!!! thing is a huge wart in the format, although in practice TRAILER!!! always has a mode of 0 and so can be distinguished from an actual file.

The use of mode 0x18000 for metadata allows for optional backwards compatibility for extraction; for encoding this can be handled with very simple postprocessing.

So my suggestion would be to have mode 0x18000 indicate extended file metadata, with the filename of the form:

optional_filename!XXXXX!

... where XXXXX indicates the type of metadata (e.g. !XATTR!). The optional_filename prefix allows an unaware decoder to extract to a well-defined name; simple postprocessing would be able to either remove (for size) or add (for compatibility) this prefix. It would be an error for this prefix, if present, to not match the name of the previous file.

I do agree that the delayed processing of an .xattr-list as you describe ought to work even with a modular initramfs.


-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.